Skip to content

Remove all used print() statements.#889

Merged
ZackAttack614 merged 8 commits intomasterfrom
remove-prints
Mar 25, 2026
Merged

Remove all used print() statements.#889
ZackAttack614 merged 8 commits intomasterfrom
remove-prints

Conversation

@ZackAttack614
Copy link
Copy Markdown
Collaborator

Resolves #350

Overview

This PR converts all useful print statements into logger statements, and removes the rest.

Affected Workflows

No workflows are affected by this PR.

Documentation Changes

No documentation changes are required for this PR.

@ZackAttack614 ZackAttack614 requested a review from psavery February 6, 2026 17:25
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.92%. Comparing base (ee7fa00) to head (a51409c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/core/material/symbols.py 0.00% 5 Missing ⚠️
hexrd/core/instrument/hedm_instrument.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   70.90%   70.92%   +0.01%     
==========================================
  Files         143      143              
  Lines       22076    22067       -9     
==========================================
- Hits        15652    15650       -2     
+ Misses       6424     6417       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ZackAttack614 and others added 2 commits March 25, 2026 08:58
@ZackAttack614 ZackAttack614 merged commit ed47a12 into master Mar 25, 2026
10 checks passed
@ZackAttack614 ZackAttack614 deleted the remove-prints branch March 25, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace any print statements with appropriate logging calls

2 participants